test: check napi_get_reference_value() during finalization#27470
Closed
addaleax wants to merge 1 commit into
Closed
test: check napi_get_reference_value() during finalization#27470addaleax wants to merge 1 commit into
napi_get_reference_value() during finalization#27470addaleax wants to merge 1 commit into
Conversation
addaleax
added
test
Collaborator
cjihrig
approved these changes
Apr 29, 2019
cjihrig
left a comment
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
The rest of this file uses NAPI_ASSERT(). Maybe this change should as well, for consistency? No big deal either way though.
Member
Author
|
@cjihrig |
Collaborator
Trott
approved these changes
May 1, 2019
Member
|
Landed in e1c838e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 1, 2019
PR-URL: nodejs#27470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2019
PR-URL: #27470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes